Re: [PATCH] pretty: Provide a strict ISO8601 date format
- From
- Scott Schmit <i.grok@comcast.net>
- Date
- Aug 29, 2014, 20:29 UTC
- Message-ID
- <20140829202916.GB10274@odin.ulthar.us>
- In-Reply-To
- <xmqq1trz6sv0.fsf@gitster.dls.corp.google.com>
On Fri, Aug 29, 2014 at 11:41:39AM -0700, Junio C Hamano wrote:
Show 8 quoted lines
> You feed tz/100 to "%+03d:" (the "sign and hour" part of the
> timezone). What if tz is -30, i.e. less than an hour but still a
> negative offset? tz/100 would be zero and tz % 100 would be -30.
>
> tz = -30;
> printf("%+03d:%02d", tz / 100, abs(tz % 100));
>
> would show what?+00:30 because zero can't be negative in two's complement arithmetic.
The "-30 / 100 = 0" part didn't click for some reason. Sorry for the noise.