Re: [PATCH] Document LF appearing in shallow command during send-pack/receive-pack

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Aug 27, 2014, 22:10 UTC
Message-ID: <20140827221017.GY20185@google.com>
In-Reply-To: <1409172416-10750-1-git-send-email-spearce@spearce.org>

Shawn Pearce wrote:

Show 18 quoted lines

> The implementation sends an LF, but the protocol documentation was
> missing this detail.
>
> Signed-off-by: Shawn Pearce <spearce@spearce.org>
> ---
>  Documentation/technical/pack-protocol.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/technical/pack-protocol.txt b/Documentation/technical/pack-protocol.txt
> index 18dea8d..569c48a 100644
> --- a/Documentation/technical/pack-protocol.txt
> +++ b/Documentation/technical/pack-protocol.txt
> @@ -467,7 +467,7 @@ references.
>  ----
>    update-request    =  *shallow command-list [pack-file]
>  
> -  shallow           =  PKT-LINE("shallow" SP obj-id)
> +  shallow           =  PKT-LINE("shallow" SP obj-id LF)

In git, the client sends LF and the server is happy with or without LF. JGit and libgit2 don't send 'shallow' lines.

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

>  
>    command-list      =  PKT-LINE(command NUL capability-list LF)
>  		       *PKT-LINE(command LF)
> --