Re: problem with def of inet_ntop() in git-compat-util.h as well as other places

From: Jeff King <peff@peff.net>
Date: Aug 27, 2014, 20:06 UTC
Message-ID: <20140827200612.GA10469@peff.net>
In-Reply-To: <805178325.32077.1409168920760.JavaMail.vpopmail@webmail2.networksolutionsemail.com>

On Wed, Aug 27, 2014 at 03:48:40PM -0400, dev wrote:

Show 10 quoted lines

> $ gzip -dc $SRC/git-2.0.4.tar.gz | tar -xf -
> $ mv git-2.0.4 git-2.0.4_SunOS5.10_sparcv9.002
> $
> $ cd git-2.0.4_SunOS5.10_sparcv9.002
> $
> $ echo $CFLAGS
> -errfmt=error -erroff=%none -errshort=full -xstrconst -xildoff -m64
> -xmemalign=8s -xnolibmil -Xa -xcode=pic32 -xregs=no%appl -xlibmieee -mc
> -g -xs -ftrap=%none -Qy -xbuiltin=%none -xdebugformat=dwarf -xunroll=1
> -xtarget=ultraT2 -xcache=8/16/4:4096/64/16

Note that git's Makefile will not read CFLAGS from the environment (you have to give it to make on the command-line, or put it in config.mak). However, running "./configure" with that in the environment should put the result into config.mak.autogen.

Show 7 quoted lines

> $ env | sort | grep LD
> BUILD=/usr/local/build
> LD=/usr/ccs/bin/sparcv9/ld
> LD_LIBRARY_PATH=/usr/local/lib:/usr/local/ssl/lib
> LD_OPTIONS=-64 -Qy
> -R/usr/local/lib/$ISALIST:/usr/local/ssl/lib/$ISALIST:/usr/local/lib:/usr/local/ssl/lib
> -L/usr/local/lib/$ISALIST:/usr/local/ssl/lib$ISALIST:/usr/local/lib:/usr/local/ssl/lib

I have never seen LD_OPTIONS before. The usual variable for this is LDFLAGS, and note that it is handled in the environment the same way as CFLAGS above.

> checking for inet_ntop... no
> checking for inet_ntop in -lresolv... no

Well, that's likely the source of some of your problems. The config.log can probably tell you more about why the check does not find inet_ntop.

Show 11 quoted lines

> Then I see in some Makefile's :
> 
> $ find . -type f -name Makefile | xargs grep "^CFLAGS" | cut -f2 -d\:
> CFLAGS = -g -O2 -Wall
> CFLAGS = -g -O2 -Wall
> CFLAGS = -g -O2 -Wall
> CFLAGS = -g -O2 -Wall
> CFLAGS = -O2 -Wall
> $
> 
> So CFLAGS is ignored entirely.

No, it's not. The Makefiles are not generated by autoconf, because autoconf is not required to build git (most of us do not use it at all). Instead, the static Makefile includes config.mak.autogen, which is generated by autoconf when you run "./configure" (and which overrides the default in the Makefile). Try grepping for CFLAGS in that file.

Show 14 quoted lines

> Also in the Makefile at the top level I see :
> 
> ifdef NO_INET_NTOP
>         LIB_OBJS += compat/inet_ntop.o
>         BASIC_CFLAGS += -DNO_INET_NTOP
> endif
> ifdef NO_INET_PTON
>         LIB_OBJS += compat/inet_pton.o
>         BASIC_CFLAGS += -DNO_INET_PTON
> endif
> 
> No reason for either of those to be defined, but I bet that you are
> right
> and they are ... and should not be.

I think they are defined by your config.mak.autogen, based on the output you showed above.

> Anyways, thanks for the input. I would love to see this "just build" and
> with a few more emails and some tinkering it should right?

I do not see anything that drastic that needs changed. Building _without_ running ./configure might even just work (it has sane defaults for many operating systems), though you would need to pass along the bits from your environment, like:

  make CFLAGS="$CFLAGS" LDFLAGS="$LD_OPTIONS"

You would potentially also need to turn off a few feature flags manually (e.g., NO_EXPAT, NO_GETTEXT). There's a complete list at the top of the Makefile. The configure script can usually figure these out for you, but the static Makefile does not.

-Peff