[PATCH v2 2/6] record_author_info: fix memory leak on malformed commit
- From
Jeff King <peff@peff.net>
- Date
- Aug 27, 2014, 07:56 UTC
- Message-ID
- <20140827075631.GB26384@peff.net>
- In-Reply-To
- <20140827075503.GA19521@peff.net>
If we hit the end-of-header without finding an "author" line, we just return from the function. We should jump to the fail_exit path to clean up the buffer that we may have allocated.
Signed-off-by: Jeff King <peff@peff.net> --- commit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/commit.c b/commit.c index b6ffd62..4ff8c66 100644 --- a/commit.c +++ b/commit.c @@ -594,7 +594,7 @@ static void record_author_date(struct author_date_slab *author_date, line_end = strchrnul(buf, '\n'); if (!skip_prefix(buf, "author ", &ident_line)) { if (!line_end[0] || line_end[1] == '\n') - return; /* end of header */ + goto fail_exit; /* end of header */ continue; } if (split_ident_line(&ident,
-- 2.1.0.346.ga0367b9