Re: [PATCH] run-command: introduce CHILD_PROCESS_INIT

From: Jeff King <peff@peff.net>
Date: Aug 17, 2014, 07:12 UTC
Message-ID: <20140817071230.GB23808@peff.net>
In-Reply-To: <53EFE15B.7030805@web.de>

On Sun, Aug 17, 2014 at 12:55:23AM +0200, René Scharfe wrote:

Show 5 quoted lines

> Most struct child_process variables are cleared using memset right after
> declaration.  Provide a macro, CHILD_PROCESS_INIT, that can be used to
> initialize them statically instead.  That's shorter, doesn't require a
> function call and is slightly more readable (especially given that we
> already have similar macros like STRBUF_INIT, ARGV_ARRAY_INIT etc.).

I think one reason we never had an INIT macro here is that you cannot simply use the struct after zero-ing it anyway. That's just the first step, and then you have to tweak a bunch of fields to get what you want. So the memset is just one setup line out of many.

Still, I think this is probably an improvement for the reasons you give above, and we can still memset() in any cases where it makes sense.

Patch itself looks obviously correct.

-Peff