git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] checkpatch: Add test for commit id formatting style in commit log

From
AMAndrew Morton <akpm@linux-foundation.org>
Date
Aug 10, 2014, 21:35 UTC
Message-ID
<20140810143500.2d556ae9.akpm@linux-foundation.org>
In-Reply-To
<1407706081.4082.21.camel@joe-AO725>
On Sun, 10 Aug 2014 14:28:01 -0700 Joe Perches <joe@perches.com> wrote:
Show 20 quoted lines
> > On Thu, Jul 3, 2014 at 12:00 AM, Joe Perches <joe@perches.com> wrote:
> > > Commit logs have various forms of commit id references.
> > >
> > > Try to standardize on a 12 character long lower case
> > > commit id along with a description of parentheses and
> > > the quoted subject line
> > >
> > > ie: commit 0123456789ab ("commit description")
> > 
> > Now this is in mainline, checkpatch starts complaining about my "too long"
> > (40 chars) commit IDs in commit messages :-(
> > 
> > 40 chars may be too long (but it's quick to copy-and-paste, as "git show"
> > shows that by default), but 12 sounds a bit short, as that's only 48 bits.
> 
> Right now, this test allows 12 to 16 byte length commit ids
> without emitting a warning.
> 
> Andrew wanted this test, I don't care how long the commit id
> is in the commit log.

Well, I mainly wanted to stop having to add "commit description" when people forget it. The length check was perhaps a bit anal. How about we make it "12 or more"?

Previous: Joe PerchesNext: Joe Perches
Message 3 of 4 in “Re: [PATCH] checkpatch: Add test for commit id formatting style in commit log”
  1. Geert UytterhoevenAug 10, 2014
  2. Joe PerchesAug 10, 2014
  3. Andrew MortonAug 10, 2014
  4. Joe PerchesAug 10, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.