Re: [PATCH] pretty.c: make git_pretty_formats_config return -1 on git_config_string failure

From: Jeff King <peff@peff.net>
Date: Aug 4, 2014, 20:33 UTC
Message-ID: <20140804203351.GA12898@peff.net>
In-Reply-To: <vpqmwbki7h3.fsf@anie.imag.fr>

On Mon, Aug 04, 2014 at 05:45:44PM +0200, Matthieu Moy wrote:

Show 10 quoted lines

> Tanay Abhra <tanayabh@gmail.com> writes:
> 
> > `git_pretty_formats_config()` continues without checking git_config_string's
> > return value which can lead to a SEGFAULT.
> 
> Indeed, without the patch:
> 
> $ git -c pretty.my= log --pretty=my                        
> error: Missing value for 'pretty.my'                         
> zsh: segmentation fault  git -c pretty.my= log --pretty=my

Hmm. Not related to the original patch, but that really looks like a bug. Shouldn't "git -c pretty.my= ..." set pretty.my to the empty string?

I'd expect "git -c pretty.my ..." to set it to NULL (i.e., the "implicit true" you get from omitting the "=" in the config files themselves).

-Peff