git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v7 3/9] replace: add test for --graft

From
Christian Couder <chriscool@tuxfamily.org>
Date
Jul 19, 2014, 15:01 UTC
Message-ID
<20140719150116.9564.48264.chriscool@tuxfamily.org>
In-Reply-To
<20140719145951.9564.61331.chriscool@tuxfamily.org>
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 t/t6050-replace.sh | 45 ++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 44 insertions(+), 1 deletion(-)
diff --git a/t/t6050-replace.sh b/t/t6050-replace.sh
index fb07ad2..f854dae 100755
--- a/t/t6050-replace.sh
+++ b/t/t6050-replace.sh
@@ -8,7 +8,7 @@ exec </dev/null
 
 . ./test-lib.sh
 
-add_and_commit_file()
+add_and_commit_file ()
 {
     _file="$1"
     _msg="$2"
@@ -18,6 +18,38 @@ add_and_commit_file()
     git commit --quiet -m "$_file: $_msg"
 }
 
+commit_buffer_contains_parents ()
+{
+    git cat-file commit "$1" >payload &&
+    sed -n -e '/^$/q' -e '/^parent /p' <payload >actual &&
+    shift &&
+    for _parent
+    do
+	echo "parent $_parent"
+    done >expected &&
+    test_cmp expected actual
+}
+
+commit_peeling_shows_parents ()
+{
+    _parent_number=1
+    _commit="$1"
+    shift &&
+    for _parent
+    do
+	_found=$(git rev-parse --verify $_commit^$_parent_number) || return 1
+	test "$_found" = "$_parent" || return 1
+	_parent_number=$(( $_parent_number + 1 ))
+    done &&
+    test_must_fail git rev-parse --verify $_commit^$_parent_number
+}
+
+commit_has_parents ()
+{
+    commit_buffer_contains_parents "$@" &&
+    commit_peeling_shows_parents "$@"
+}
+
 HASH1=
 HASH2=
 HASH3=
@@ -351,4 +383,15 @@ test_expect_success 'replace ref cleanup' '
 	test -z "$(git replace)"
 '
 
+test_expect_success '--graft with and without already replaced object' '
+	test $(git log --oneline | wc -l) = 7 &&
+	git replace --graft $HASH5 &&
+	test $(git log --oneline | wc -l) = 3 &&
+	commit_has_parents $HASH5 &&
+	test_must_fail git replace --graft $HASH5 $HASH4 $HASH3 &&
+	git replace --force -g $HASH5 $HASH4 $HASH3 &&
+	commit_has_parents $HASH5 $HASH4 $HASH3 &&
+	git replace -d $HASH5
+'
+
 test_done
-- 
2.0.0.421.g786a89d.dirty
Previous: Christian CouderNext: Christian Couder
Message 4 of 11 in “Add --graft option to git replace”
  1. 0/9 Add --graft option to git replaceChristian Couder, Jul 19, 2014
  2. 1/9 replace: cleanup redirection style in testsChristian Couder, Jul 19, 2014
  3. 2/9 replace: add --graft optionChristian Couder, Jul 19, 2014
  4. 3/9 replace: add test for --graftChristian Couder, Jul 19, 2014
  5. 4/9 Documentation: replace: add --graft optionChristian Couder, Jul 19, 2014
  6. 5/9 contrib: add convert-grafts-to-replace-refs.shChristian Couder, Jul 19, 2014
  7. 6/9 replace: remove signature when using --graftChristian Couder, Jul 19, 2014
  8. 7/9 replace: add test for --graft with signed commitChristian Couder, Jul 19, 2014
  9. 8/9 replace: check mergetags when using --graftChristian Couder, Jul 19, 2014
  10. 9/9 replace: add test for --graft with a mergetagChristian Couder, Jul 19, 2014
  11. Junio C HamanoJul 21, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.