Re: move detection doesnt take filename into account

From: Jeff King <peff@peff.net>
Date: Jul 9, 2014, 06:45 UTC
Message-ID: <20140709064521.GA14682@sigill.intra.peff.net>
In-Reply-To: <xmqq61jhxb0g.fsf@gitster.dls.corp.google.com>

On Tue, Jul 01, 2014 at 10:08:15AM -0700, Junio C Hamano wrote:

Show 6 quoted lines

> I didn't think it through but my gut feeling is that we could change
> the name similarity score to be the length of the tail part that
> matches (e.g. 1.a to a/2.a that has the same two bytes at the tail
> is a better match than to a/2.b that does not share any tail, and to
> a/1.a that shares the three bytes at the tail is an even better
> match).

The delta heuristics in pack-objects use pack_name_hash, which claims:

        /*
         * This effectively just creates a sortable number from the
         * last sixteen non-whitespace characters. Last characters
         * count "most", so things that end in ".c" sort together.
         */

which might be another option (and seems like a superset of the basename check, short of basenames that are longer than 16 characters).

-Peff