Re: [PATCH 4/8] add functions for memory-efficient bitmaps

From: Jeff King <peff@peff.net>
Date: Jul 1, 2014, 17:18 UTC
Message-ID: <20140701171759.GB7282@sigill.intra.peff.net>
In-Reply-To: <xmqqegy5xbiu.fsf@gitster.dls.corp.google.com>

On Tue, Jul 01, 2014 at 09:57:13AM -0700, Junio C Hamano wrote:

Show 9 quoted lines

> Another thing I noticed was that the definition of and the
> commentary on bitset_equal() and bitset_empty() sounded somewhat
> "undecided".  These functions take "max" that is deliberately named
> differently from "num_bits" (the width of the bitsets involved),
> inviting to use them for testing only earlier bits in the bitset as
> long as the caller understands the caveat, but the caveat requires
> that the partial bitset to test must be byte-aligned, which makes it
> not very useful in practice, which means we probably do not want
> them to be used for any "max" other than "num_bits".

Yeah, I added that comment because I found "max" to be confusing, but couldn't think of a better name. I'm not sure why "num_bits" did not occur to me, as that makes it completely obvious.

>  * take "num_bits", not "max", to clarify that callers must use them
>    only on the full bitset.

This seems like the right solution to me. Handling partially aligned bytes adds to the complexity and may hurt performance (in fact, I think bitset_equal could actually just call memcmp, which I should fix). That's fine if callers care about that feature, but I actually don't anticipate any that do.

By the way, I chose "unsigned char" as the storage format somewhat arbitrarily. Performance might be better with "unsigned int" or even "unsigned long". It means potentially wasting more space, but not more than one word (minus a byte) per commit (so about 3MB on linux.git). I'll try to do some timings to see if it's worth doing.

Show 5 quoted lines

> In either case, there needs another item in the "caller's responsibility"
> list at the beginning of bitset.h:
> 
>     4. Ensure that padding bits at the end of the bitset array are
>        initialized to 0.

Agreed. That is definitely a requirement I had in mind, but I didn't think to write it down.

I'll fix both points in the re-roll.

-Peff