[PATCH 2/7] record_author_info: fix memory leak on malformed commit

From: Jeff King <peff@peff.net>
Date: Jun 18, 2014, 20:28 UTC
Message-ID: <20140618202849.GB23896@sigill.intra.peff.net>
In-Reply-To: <20140618201944.GA23238@sigill.intra.peff.net>

If we hit the end-of-header without finding an "author" line, we just return from the function. We should jump to the fail_exit path to clean up the buffer that we may have allocated.

Signed-off-by: Jeff King <peff@peff.net>
---
 commit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/commit.c b/commit.c
index d04b525..0c40cfa 100644
--- a/commit.c
+++ b/commit.c
@@ -617,7 +617,7 @@ static void record_author_date(struct author_date_slab *author_date,
 		ident_line = skip_prefix(buf, "author ");
 		if (!ident_line) {
 			if (!line_end[0] || line_end[1] == '\n')
-				return; /* end of header */
+				goto fail_exit; /* end of header */
 			continue;
 		}
 		if (split_ident_line(&ident,

-- 
2.0.0.566.gfe3e6b2