[PATCH 11/17] use get_cached_commit_buffer where appropriate
- From
Jeff King <peff@peff.net>
- Date
- Jun 10, 2014, 21:40 UTC
- Message-ID
- <20140610214046.GK19147@sigill.intra.peff.net>
- In-Reply-To
- <20140610213509.GA26979@sigill.intra.peff.net>
Some call sites check commit->buffer to see whether we have a cached buffer, and if so, do some work with it. In the long run we may want to switch these code paths to make their decision on a different boolean flag (because checking the cache may get a little more expensive in the future). But for now, we can easily support them by converting the calls to use get_cached_commit_buffer.
Signed-off-by: Jeff King <peff@peff.net> --- builtin/rev-list.c | 2 +- log-tree.c | 2 +- object.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/builtin/rev-list.c b/builtin/rev-list.c index e012ebe..3fcbf21 100644 --- a/builtin/rev-list.c +++ b/builtin/rev-list.c @@ -106,7 +106,7 @@ static void show_commit(struct commit *commit, void *data) else putchar('\n'); - if (revs->verbose_header && commit->buffer) { + if (revs->verbose_header && get_cached_commit_buffer(commit)) { struct strbuf buf = STRBUF_INIT; struct pretty_print_context ctx = {0}; ctx.abbrev = revs->abbrev; diff --git a/log-tree.c b/log-tree.c index cf2f86c..e9ef8ab 100644 --- a/log-tree.c +++ b/log-tree.c @@ -588,7 +588,7 @@ void show_log(struct rev_info *opt) show_mergetag(opt, commit); } - if (!commit->buffer) + if (!get_cached_commit_buffer(commit)) return; if (opt->show_notes) { diff --git a/object.c b/object.c index 44ca657..67b6e35 100644 --- a/object.c +++ b/object.c @@ -197,7 +197,7 @@ struct object *parse_object_buffer(const unsigned char *sha1, enum object_type t if (commit) { if (parse_commit_buffer(commit, buffer, size)) return NULL; - if (!commit->buffer) { + if (!get_cached_commit_buffer(commit)) { set_commit_buffer(commit, buffer); *eaten_p = 1; }
-- 2.0.0.729.g520999f