[PATCH 3/6] repack: s/write_bitmap/&s/ in code
- From
Jeff King <peff@peff.net>
- Date
- Jun 10, 2014, 20:10 UTC
- Message-ID
- <20140610201007.GC14974@sigill.intra.peff.net>
- In-Reply-To
- <20140610200741.GA11248@sigill.intra.peff.net>
The config name is "writeBitmaps", so the internal variable missing the plural is unnecessarily confusing to write.
Signed-off-by: Jeff King <peff@peff.net> --- Obviously not critical, but after getting it wrong several times while working on the code, I was inspired to write this.
builtin/repack.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/builtin/repack.c b/builtin/repack.c index fab9989..36c1cf9 100644 --- a/builtin/repack.c +++ b/builtin/repack.c @@ -10,7 +10,7 @@ static int delta_base_offset = 1; static int pack_kept_objects = -1; -static int write_bitmap = -1; +static int write_bitmaps = -1; static char *packdir, *packtmp; static const char *const git_repack_usage[] = { @@ -29,7 +29,7 @@ static int repack_config(const char *var, const char *value, void *cb) return 0; } if (!strcmp(var, "pack.writebitmaps")) { - write_bitmap = git_config_bool(var, value); + write_bitmaps = git_config_bool(var, value); return 0; } return git_default_config(var, value, cb); @@ -172,7 +172,7 @@ int cmd_repack(int argc, const char **argv, const char *prefix) OPT__QUIET(&quiet, N_("be quiet")), OPT_BOOL('l', "local", &local, N_("pass --local to git-pack-objects")), - OPT_BOOL('b', "write-bitmap-index", &write_bitmap, + OPT_BOOL('b', "write-bitmap-index", &write_bitmaps, N_("write bitmap index")), OPT_STRING(0, "unpack-unreachable", &unpack_unreachable, N_("approxidate"), N_("with -A, do not loosen objects older than this")), @@ -195,7 +195,7 @@ int cmd_repack(int argc, const char **argv, const char *prefix) git_repack_usage, 0); if (pack_kept_objects < 0) - pack_kept_objects = write_bitmap > 0; + pack_kept_objects = write_bitmaps > 0; packdir = mkpathdup("%s/pack", get_object_directory()); packtmp = mkpathdup("%s/.tmp-%d-pack", packdir, (int)getpid()); @@ -221,9 +221,9 @@ int cmd_repack(int argc, const char **argv, const char *prefix) argv_array_pushf(&cmd_args, "--no-reuse-delta"); if (no_reuse_object) argv_array_pushf(&cmd_args, "--no-reuse-object"); - if (write_bitmap >= 0) + if (write_bitmaps >= 0) argv_array_pushf(&cmd_args, "--%swrite-bitmap-index", - write_bitmap ? "" : "no-"); + write_bitmaps ? "" : "no-"); if (pack_everything & ALL_INTO_ONE) { get_non_kept_pack_filenames(&existing_packs);
-- 2.0.0.729.g520999f