Re: [PATCH 05/20] contrib/examples/git-repack.sh: avoid "test <cond> -a/-o <cond>"
On Fri, Jun 06, 2014 at 07:55:48AM -0700, Elia Pinto wrote:
Show 23 quoted lines
> The construct is error-prone; "test" being built-in in most modern
> shells, the reason to avoid "test <cond> && test <cond>" spawning
> one extra process by using a single "test <cond> -a <cond>" no
> longer exists.
>
> Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
> ---
> contrib/examples/git-repack.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/contrib/examples/git-repack.sh b/contrib/examples/git-repack.sh
> index f312405..96e3fed 100755
> --- a/contrib/examples/git-repack.sh
> +++ b/contrib/examples/git-repack.sh
> @@ -76,8 +76,8 @@ case ",$all_into_one," in
> existing="$existing $e"
> fi
> done
> - if test -n "$existing" -a -n "$unpack_unreachable" -a \
> - -n "$remove_redundant"
> + if test -n "$existing" && test -n "$unpack_unreachable" && \
> + test -n "$remove_redundant"
> then
I do not think the traling "\" is needed anymore; the "&&" takes care of it.
--
David
David Aguilar <davvid@gmail.com>