git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] pack-objects: use free()+xcalloc() instead of xrealloc()+memset()

From
Jeff King <peff@peff.net>
Date
Jun 2, 2014, 19:42 UTC
Message-ID
<20140602194246.GD2510@sigill.intra.peff.net>
In-Reply-To
<538B0969.9080409@web.de>
On Sun, Jun 01, 2014 at 01:07:21PM +0200, René Scharfe wrote:
Show 16 quoted lines
> Whenever the hash table becomes too small then its size is increased,
> the original part (and the added space) is zerod out using memset(),
> and the table is rebuilt from scratch.
> 
> Simplify this proceess by returning the old memory using free() and
> allocating the new buffer using xcalloc(), which already clears the
> buffer for us.  That way we avoid copying the old hash table contents
> needlessly inside xrealloc().
> 
> While at it, use the first array member with sizeof instead of a
> specific type.  The old code used uint32_t and int, while index is
> actually an array of int32_t.  Their sizes are the same basically
> everywhere, so it's not actually a problem, but the new code is
> cleaner and doesn't have to be touched should the type be changed.
> 
> Signed-off-by: Rene Scharfe <l.s.r@web.de>
Looks good to me.

BTW, the code does git-blame to Vicent's 2834bc2 (which I also worked on), but actually originated in 7a979d9 (Thin pack - create packfile with missing delta base., 2006-02-19). Not that it matters, but I was just surprised since the code you are changing did not seem familiar to me. I guess there was just too much refactoring during the code movement for git-blame to pass along the blame in this case.

-Peff
Previous: René ScharfeNext: David Kastrup
Message 2 of 6 in “pack-objects: use free()+xcalloc() instead of xrealloc()+memset()”
  1. pack-objects: use free()+xcalloc() instead of xrealloc()+memset()René Scharfe, Jun 1, 2014
  2. Jeff KingJun 2, 2014
  3. David KastrupJun 2, 2014
  4. Jeff KingJun 2, 2014
  5. Junio C HamanoJun 2, 2014
  6. Jeff KingJun 3, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.