git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] sideband.c: Get rid of ANSI sequences for non-terminal shell

From
Jeff King <peff@peff.net>
Date
May 29, 2014, 17:45 UTC
Message-ID
<20140529174516.GA10865@sigill.intra.peff.net>
In-Reply-To
<81E85F13A4BE084BAF4B1AA24173EDA012924D8B@JWPKEXMBX03.corp.checkfree.com>
On Wed, May 28, 2014 at 03:12:15AM +0000, Naumov, Michael (North Sydney) wrote:
Show 9 quoted lines
> Some git tools such as GitExtensions for Windows use environment
> variable TERM=msys which causes the weird ANSI sequence shown for the
> messages returned from server-side hooks
> We add those ANSI sequences to help format sideband data on the user's
> terminal. However, GitExtensions is not using a terminal, and the ANSI
> sequences just confuses it. We can recognize this use by checking
> isatty().
> See https://github.com/gitextensions/gitextensions/issues/1313 for
> more details

Please wrap your commit messages (and emails) at something reasonable to fit on an 80-char terminal with indentation (I usually use 60, but anything <= 72 is probably fine).

Other than that, I think the patch looks fine.
> P.S. I gave up trying to send this letter from gmail, it eats my tab character
> P.S 2. Sorry, my tab character has been eaten again!
This version looks OK to me (and applies via git-am).
-Peff
Previous: Naumov, Michael (North Sydney)
Message 2 of 2 in “sideband.c: Get rid of ANSI sequences for non-terminal shell”
  1. sideband.c: Get rid of ANSI sequences for non-terminal shellNaumov, Michael (North Sydney), May 28, 2014
  2. Jeff KingMay 29, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.