git-multimail: migration: Config is not iterable

From: Azat Khuzhin <a3at.mail@gmail.com>
Date: May 29, 2014, 14:22 UTC
Message-ID: <20140529142208.GB27005@azat>

Hi there,

Using the latest version of git-multimail there is an issue with migration:

$ ~azat/git-multimail/git-multimail/migrate-mailhook-config --overwrite
Traceback (most recent call last):
  File "/home/azat/git-multimail/git-multimail/migrate-mailhook-config", line 271, in <module>
    main(sys.argv[1:])
  File "/home/azat/git-multimail/git-multimail/migrate-mailhook-config", line 268, in main
    migrate_config(strict=options.strict, retain=options.retain, overwrite=options.overwrite)
  File "/home/azat/git-multimail/git-multimail/migrate-mailhook-config", line 159, in migrate_config
    if not _check_old_config_exists(old):
  File "/home/azat/git-multimail/git-multimail/migrate-mailhook-config", line 66, in _check_old_config_exists
    if name in old:
TypeError: argument of type 'Config' is not iterable

Tested on 2.6 and 2.7 python versions.

If you revert 09d0d5b92203f019763e43cef1e57f76f117d2b4 ("Get Python files to pass pep8's tests.") there issue goes away. I understand that this is not the right solution and I'm not the guru of python, so just let you know.

Thanks