Re: [PATCH] check_refname_component: Optimize
- From
brian m. carlson <sandals@crustytoothpaste.net>
- Date
- May 29, 2014, 12:19 UTC
- Message-ID
- <20140529121926.GA47385@vauxhall.crustytoothpaste.net>
- In-Reply-To
- <1401307055-11603-1-git-send-email-dturner@twitter.com>
On Wed, May 28, 2014 at 03:57:35PM -0400, David Turner wrote:
> +ifdef NO_SSE > + BASIC_CFLAGS += -DNO_SSE
This is not a great name. This implies the system does not have SSE (SSE 1), but in fact what you're concerned about is SSE 4. This will be confusing for users of older x86-64 processors, where SSE and SSE 2 are architecturally guaranteed even though SSE 4 is not present.
> +else > + BASIC_CFLAGS += -msse4 > +endif
You probably also want to autodetect when the system is not x86(-64)? and turn this off. I doubt PowerPC/SPARC/ARM users are going to want to have to disable it manually.
-- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187