Re: [PATCH v2] Get rid of the non portable shell export VAR=VALUE costruct
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- May 23, 2014, 18:44 UTC
- Message-ID
- <20140523184405.GE12314@google.com>
- In-Reply-To
- <xmqqmwe8jr44.fsf@gitster.dls.corp.google.com>
Junio C Hamano wrote:
> Elia Pinto <gitter.spiros@gmail.com> writes:
Show 5 quoted lines
>> Found by check-non-portable-shell.pl > > Thanks. > > Makes me wonder why these two were missed, though.
Good catch. check-non-portable-shell.pl uses an anchored regex:
/^\s*export\s+[^=]*=/
Perhaps something like
/\bexport\s+[A-Za-z0-9_]*=/
without anchoring would work better.
-- >8 -- Subject: test-lint: find unportable sed, echo, test, and export usage after &&
Instead of anchoring these checks with "^\s*", just check that the usage is preceded by a word boundary. So now we can catch
test $cond && export foo=bar
just like we already catch
test $cond && export foo=bar
As a side effect, this will detect usage of "sed -i", "echo -n", "test a == b", and "export a=b" in comments. That is not ideal but it's potentially useful because people sometimes copy code from comments so it can be good to also avoid nonportable patterns there.
To avoid false positives, keep the checks for 'declare' and 'which' anchored. Those are frequently used words in normal English-language comments.
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> --- t/check-non-portable-shell.pl | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git i/t/check-non-portable-shell.pl w/t/check-non-portable-shell.pl index 45971f4..b170cbc 100755 --- i/t/check-non-portable-shell.pl +++ w/t/check-non-portable-shell.pl @@ -16,12 +16,12 @@ sub err { while (<>) { chomp; - /^\s*sed\s+-i/ and err 'sed -i is not portable'; - /^\s*echo\s+-n/ and err 'echo -n is not portable (please use printf)'; + /\bsed\s+-i/ and err 'sed -i is not portable'; + /\becho\s+-n/ and err 'echo -n is not portable (please use printf)'; /^\s*declare\s+/ and err 'arrays/declare not portable'; /^\s*[^#]\s*which\s/ and err 'which is not portable (please use type)'; - /test\s+[^=]*==/ and err '"test a == b" is not portable (please use =)'; - /^\s*export\s+[^=]*=/ and err '"export FOO=bar" is not portable (please use FOO=bar && export FOO)'; + /\btest\s+[^=]*==/ and err '"test a == b" is not portable (please use =)'; + /\bexport\s+[A-Za-z0-9_]*=/ and err '"export FOO=bar" is not portable (please use FOO=bar && export FOO)'; # this resets our $. for each file close ARGV if eof; }