git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC] t0000-*.sh: Fix the GIT_SKIP_TESTS sub-tests

From
Jonathan Nieder <jrnieder@gmail.com>
Date
May 20, 2014, 21:40 UTC
Message-ID
<20140520214006.GT12314@google.com>
In-Reply-To
<537BC8A2.9060009@ramsay1.demon.co.uk>
Ramsay Jones wrote:
Show 10 quoted lines
> --- a/t/t0000-basic.sh
> +++ b/t/t0000-basic.sh
> @@ -296,8 +296,9 @@ test_expect_success 'test --verbose-only' '
>  '
>  
>  test_expect_success 'GIT_SKIP_TESTS' "
> -	GIT_SKIP_TESTS='git.2' \
> -		run_sub_test_lib_test git-skip-tests-basic \
> +	GIT_SKIP_TESTS='git.2' && export GIT_SKIP_TESTS &&
> +	test_when_finished sane_unset GIT_SKIP_TESTS &&
Oof.  Good catch.

What should happen if I have set GIT_SKIP_TESTS explicitly to run only some of the tests in t0000-basic?

Thanks, Jonathan

Previous: Junio C HamanoNext: Ramsay Jones
Message 3 of 6 in “t0000-*.sh: Fix the GIT_SKIP_TESTS sub-tests”
  1. t0000-*.sh: Fix the GIT_SKIP_TESTS sub-testsRamsay Jones, May 20, 2014
  2. Junio C HamanoMay 20, 2014
  3. Jonathan NiederMay 20, 2014
  4. Ramsay JonesMay 20, 2014
  5. Jonathan NiederMay 20, 2014
  6. Ramsay JonesMay 20, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.