Re: [PATCH/RFC] send-pack.c: Allow to disable side-band-64k
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- May 19, 2014, 19:33 UTC
- Message-ID
- <20140519193340.GP12314@google.com>
- In-Reply-To
- <1400526434-3132-1-git-send-email-thomas.braun@byte-physics.de>
Hi,
Thomas Braun wrote:
> pushing over the dump git protocol with a windows git client.
I've never heard of the dump git protocol. Do you mean the git protocol that's used with git:// URLs?
[...]
> Alternative approaches considered but deemed too invasive: > - Rewrite read/write wrappers in mingw.c in order to distinguish between > a file descriptor which has a socket behind and a file descriptor > which has a file behind.
I assume here "too invasive" means "too much engineering effort"?
It sounds like a clean fix, not too invasive at all. But I can understand wanting a stopgap in the meantime.
> - Turning the capability side-band-64k off completely. This would remove a useful > feature for users of non-affected transport protocols.
Would it make sense to turn off sideband unconditionally on Windows when using the relevant protocols?
I assume someone on the list wouldn't mind writing such a patch, so I don't think the engineering effort would be a problem for that.
Thanks, Jonathan
-- -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en --- You received this message because you are subscribed to the Google Groups "msysGit" group. To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.