[PATCH/RFC] Always auto-gc after calling a fast-import transport
- From
Stepan Kasal <kasal@ucw.cz>
- Date
- May 15, 2014, 05:37 UTC
- Message-ID
- <20140515053722.GB12133@camelia.ucw.cz>
From: Johannes Schindelin <johannes.schindelin@gmx.de> Date: Mon, 9 Apr 2012 13:04:35 -0500
After importing anything with fast-import, we should always let the garbage collector do its job, since the objects are written to disk inefficiently.
This brings down an initial import of http://selenic.com/hg from about 230 megabytes to about 14.
In the future, we may want to make this configurable on a per-remote basis, or maybe teach fast-import about it in the first place.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Stepan Kasal <kasal@ucw.cz> ---
Hello, another patch that waited in msysgit for 2 years. Could anyone on the list try to reproduce the performance problem that triggered this?
Thanks, Stepan
transport-helper.c | 8 ++++++++ 1 file changed, 8 insertions(+)
diff --git a/transport-helper.c b/transport-helper.c index a01ea47..956b800 100644 --- a/transport-helper.c +++ b/transport-helper.c @@ -14,6 +14,8 @@ #include "refs.h" static int debug; +/* TODO: put somewhere sensible, e.g. git_transport_options? */ +static int auto_gc = 1; struct helper_data { const char *name; @@ -519,6 +521,12 @@ static int fetch_with_import(struct transport *transport, } } strbuf_release(&buf); + if (auto_gc) { + const char *argv_gc_auto[] = { + "gc", "--auto", "--quiet", NULL, + }; + run_command_v_opt(argv_gc_auto, RUN_GIT_CMD); + } return 0; }
-- 1.9.2.msysgit.0.335.gd2a461f -- -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en --- You received this message because you are subscribed to the Google Groups "msysGit" group. To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.