git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v6 05/42] update-ref.c: log transaction error from the update_ref

From
Jonathan Nieder <jrnieder@gmail.com>
Date
May 14, 2014, 22:08 UTC
Message-ID
<20140514220831.GB9218@google.com>
In-Reply-To
<1398976662-6962-6-git-send-email-sahlberg@google.com>
Hi,
Ronnie Sahlberg wrote:
> --- a/builtin/update-ref.c
> +++ b/builtin/update-ref.c
> @@ -342,6 +342,7 @@ int cmd_update_ref(int argc, const char **argv, const char *prefix)
[...]
> @@ -359,17 +360,16 @@ int cmd_update_ref(int argc, const char **argv, const char *prefix)
[...]
Show 11 quoted lines
>  		if (delete || no_deref || argc > 0)
>  			usage_with_options(git_update_ref_usage, options);
>  		if (end_null)
>  			line_termination = '\0';
>  		update_refs_stdin();
> -		ret = ref_transaction_commit(transaction, msg, NULL,
> -					     UPDATE_REFS_DIE_ON_ERR);
> -		return ret;
> +		if (ref_transaction_commit(transaction, msg, &err,
> +					   UPDATE_REFS_QUIET_ON_ERR))
> +			die("%s", err.buf);

Nice. I like this much more than passing a flag to each function to tell it how to handle errors. :)

ref_transaction_commit didn't have any stray codepaths that return some other exit code instead of die()-ing with UPDATE_REFS_DIE_ON_ERR, so this should be safe as far as the exit code is concerned.

The only danger would be that some codepath leaves 'err' alone and forgets to write a messages, so we die with

	"fatal: "
Alas, it looks like this patch can do that.
 i. The call to update_ref_write can error out without updating the
    error string.
 ii. delete_ref_loose can print a message and then fail without updating
     the error string so the output looks like
	warning: unable to unlink .git/refs/heads/master.lock: Permission denied
	fatal:
	$
 iii. repack_without_refs can similarly return an error
	error: Unable to create '/home/jrn/test/.git/packed-refs.lock: Permission denied
	error: cannot delete 'refs/heads/master' from packed refs
	fatal:
	$
 iv. commit_lock_file in commit_packed_refs is silent on error.
     repack_without_refs probably intends to write a message in that
     case but doesn't :(

I wish there were some way to automatically detect missed spots or make them stand out (like with the current "return error()" idiom a bare "return -1" stands out).

(i) is fixed by a later patch. It would be better to put that before this one for bisectability.

I don't see fixes to (ii), (iii), and (iv) in the series yet from a quick glance.

Thanks, Jonathan

Previous: Ronnie SahlbergNext: Ronnie Sahlberg
Message 14 of 78 in “Use ref transactions for all ref updates”
  1. 00/42 Use ref transactions for all ref updatesRonnie Sahlberg, May 1, 2014
  2. 01/42 refs.c: constify the sha arguments for ref_transaction_create|delete|updateRonnie Sahlberg, May 1, 2014
  3. 02/42 refs.c: allow passing NULL to ref_transaction_freeRonnie Sahlberg, May 1, 2014
  4. Jonathan NiederMay 13, 2014
  5. Ronnie SahlbergMay 13, 2014
  6. Ronnie SahlbergMay 14, 2014
  7. 03/42 refs.c: add a strbuf argument to ref_transaction_commit for error loggingRonnie Sahlberg, May 1, 2014
  8. Jonathan NiederMay 13, 2014
  9. Ronnie SahlbergMay 14, 2014
  10. 04/42 refs.c: make ref_update_reject_duplicates take a strbuf argument for errorsRonnie Sahlberg, May 1, 2014
  11. Jonathan NiederMay 14, 2014
  12. Ronnie SahlbergMay 14, 2014
  13. 05/42 update-ref.c: log transaction error from the update_refRonnie Sahlberg, May 1, 2014
  14. Jonathan NiederMay 14, 2014
  15. Ronnie SahlbergMay 15, 2014
  16. 06/42 refs.c: make update_ref_write update a strbuf on failureRonnie Sahlberg, May 1, 2014
  17. Jonathan NiederMay 14, 2014
  18. 07/42 refs.c: remove the onerr argument to ref_transaction_commitRonnie Sahlberg, May 1, 2014
  19. Jonathan NiederMay 14, 2014
  20. 08/42 refs.c: change ref_transaction_update() to do error checking and return statusRonnie Sahlberg, May 1, 2014
  21. Michael HaggertyMay 5, 2014
  22. Ronnie SahlbergMay 5, 2014
  23. Jonathan NiederMay 14, 2014
  24. Ronnie SahlbergMay 15, 2014
  25. 09/42 refs.c: change ref_transaction_create to do error checking and return statusRonnie Sahlberg, May 1, 2014
  26. Jonathan NiederMay 15, 2014
  27. Ronnie SahlbergMay 15, 2014
  28. Jonathan NiederMay 15, 2014
  29. 10/42 refs.c: ref_transaction_delete to check for error and return statusRonnie Sahlberg, May 1, 2014
  30. Jonathan NiederMay 15, 2014
  31. Ronnie SahlbergMay 15, 2014
  32. 11/42 tag.c: use ref transactions when doing updatesRonnie Sahlberg, May 1, 2014
  33. Jonathan NiederMay 15, 2014
  34. Ronnie SahlbergMay 15, 2014
  35. Jonathan NiederMay 15, 2014
  36. 12/42 replace.c: use the ref transaction functions for updatesRonnie Sahlberg, May 1, 2014
  37. Jonathan NiederMay 15, 2014
  38. Ronnie SahlbergMay 15, 2014
  39. 13/42 commit.c: use ref transactions for updatesRonnie Sahlberg, May 1, 2014
  40. Jonathan NiederMay 15, 2014
  41. Ronnie SahlbergMay 15, 2014
  42. 14/42 sequencer.c: use ref transactions for all ref updatesRonnie Sahlberg, May 1, 2014
  43. Jonathan NiederMay 15, 2014
  44. 15/42 fast-import.c: change update_branch to use ref transactionsRonnie Sahlberg, May 1, 2014
  45. 16/42 branch.c: use ref transaction for all ref updatesRonnie Sahlberg, May 1, 2014
  46. 17/42 refs.c: change update_ref to use a transactionRonnie Sahlberg, May 1, 2014
  47. 18/42 refs.c: free the transaction before returning when number of updates is 0Ronnie Sahlberg, May 1, 2014
  48. 19/42 refs.c: ref_transaction_commit should not free the transactionRonnie Sahlberg, May 1, 2014
  49. 20/42 fetch.c: clear errno before calling functions that might set itRonnie Sahlberg, May 1, 2014
  50. Eric SunshineMay 2, 2014
  51. Ronnie SahlbergMay 2, 2014
  52. 21/42 fetch.c: change s_update_ref to use a ref transactionRonnie Sahlberg, May 1, 2014
  53. 22/42 fetch.c: use a single ref transaction for all ref updatesRonnie Sahlberg, May 1, 2014
  54. 23/42 receive-pack.c: use a reference transaction for updating the refsRonnie Sahlberg, May 1, 2014
  55. 24/42 fast-import.c: use a ref transaction when dumping tagsRonnie Sahlberg, May 1, 2014
  56. 25/42 walker.c: use ref transaction for ref updatesRonnie Sahlberg, May 1, 2014
  57. 26/42 refs.c: make write_ref_sha1 staticRonnie Sahlberg, May 1, 2014
  58. 27/42 refs.c: make lock_ref_sha1 staticRonnie Sahlberg, May 1, 2014
  59. 28/42 refs.c: add transaction.status and track OPEN/CLOSED/ERRORRonnie Sahlberg, May 1, 2014
  60. 29/42 refs.c: remove the update_ref_lock functionRonnie Sahlberg, May 1, 2014
  61. 30/42 refs.c: remove the update_ref_write functionRonnie Sahlberg, May 1, 2014
  62. 31/42 refs.c: remove lock_ref_sha1Ronnie Sahlberg, May 1, 2014
  63. 32/42 refs.c: make prune_ref use a transaction to delete the refRonnie Sahlberg, May 1, 2014
  64. 33/42 refs.c: make delete_ref use a transactionRonnie Sahlberg, May 1, 2014
  65. 34/42 refs.c: pass the ref log message to _create/delete/update instead of _commitRonnie Sahlberg, May 1, 2014
  66. 35/42 refs.c: pass NULL as *flags to read_ref_fullRonnie Sahlberg, May 1, 2014
  67. 36/42 refs.c: pack all refs before we start to rename a refRonnie Sahlberg, May 1, 2014
  68. 37/42 refs.c: move the check for valid refname to lock_ref_sha1_basicRonnie Sahlberg, May 1, 2014
  69. 38/42 refs.c: call lock_ref_sha1_basic directly from commitRonnie Sahlberg, May 1, 2014
  70. 39/42 refs.c: add a new flag for transaction delete for refs we know are packed onlyRonnie Sahlberg, May 1, 2014
  71. 40/42 refs.c: pass a skip list to name_conflict_fnRonnie Sahlberg, May 1, 2014
  72. Eric SunshineMay 2, 2014
  73. Ronnie SahlbergMay 2, 2014
  74. 41/42 refs.c: make rename_ref use a transactionRonnie Sahlberg, May 1, 2014
  75. 42/42 refs.c: remove forward declaraion of write_ref_sha1Ronnie Sahlberg, May 1, 2014
  76. Michael HaggertyMay 5, 2014
  77. Ronnie SahlbergMay 5, 2014
  78. Jonathan NiederMay 13, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.