git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] wincred: add install target and avoid overwriting configured variables

From
Stepan Kasal <kasal@ucw.cz>
Date
Apr 30, 2014, 06:46 UTC
Message-ID
<20140430064610.GA22094@camelia.ucw.cz>
From: Pat Thoyts <patthoyts@users.sourceforge.net>
Date: Wed, 24 Oct 2012 00:15:29 +0100
Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>
Signed-off-by: Stepan Kasal <kasal@ucw.cz>
---
Another one from msysGit project.
Original subject by Pat; I would suggest:
    wincred: improve Makefile
 contrib/credential/wincred/Makefile | 22 ++++++++++++++--------
 1 file changed, 14 insertions(+), 8 deletions(-)
diff --git a/contrib/credential/wincred/Makefile b/contrib/credential/wincred/Makefile
index bad45ca..3ce6aba 100644
--- a/contrib/credential/wincred/Makefile
+++ b/contrib/credential/wincred/Makefile
@@ -1,14 +1,20 @@
-all: git-credential-wincred.exe
-
-CC = gcc
-RM = rm -f
-CFLAGS = -O2 -Wall
-
 -include ../../../config.mak.autogen
 -include ../../../config.mak
 
-git-credential-wincred.exe : git-credential-wincred.c
+prefix ?= /usr/local
+libexecdir ?= $(prefix)/libexec/git-core
+
+INSTALL ?= install
+
+GIT_CREDENTIAL_WINCRED := git-credential-wincred.exe
+
+all: $(GIT_CREDENTIAL_WINCRED)
+
+$(GIT_CREDENTIAL_WINCRED): git-credential-wincred.c
 	$(LINK.c) $^ $(LOADLIBES) $(LDLIBS) -o $@
 
+install: $(GIT_CREDENTIAL_WINCRED)
+	$(INSTALL) -m 755 $(GIT_CREDENTIAL_WINCRED) $(libexecdir)
+
 clean:
-	$(RM) git-credential-wincred.exe
+	$(RM) $(GIT_CREDENTIAL_WINCRED)
-- 
1.9.2.msysgit.0.158.g6070cee
Next: Erik Faye-Lund
Message 1 of 12 in “wincred: add install target and avoid overwriting configured variables”
  1. wincred: add install target and avoid overwriting configured variablesStepan Kasal, Apr 30, 2014
  2. Erik Faye-LundApr 30, 2014
  3. Stepan KasalApr 30, 2014
  4. Erik Faye-LundApr 30, 2014
  5. 0/2 wincred makefile changesStepan Kasal, May 13, 2014
  6. 1/2 wincred: add install targetStepan Kasal, May 13, 2014
  7. 2/2 wincred: avoid overwriting configured variablesStepan Kasal, May 13, 2014
  8. Erik Faye-LundMay 13, 2014
  9. 2/2 wincred: avoid overwriting configured variablesStepan Kasal, May 13, 2014
  10. Felipe ContrerasMay 13, 2014
  11. Stepan KasalMay 13, 2014
  12. Erik Faye-LundMay 14, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.