[PATCH v1 0/4] replace: add option to edit a Git object
- From
Christian Couder <chriscool@tuxfamily.org>
- Date
- Apr 26, 2014, 20:00 UTC
- Message-ID
- <20140426194404.21546.82305.chriscool@tuxfamily.org>
This patch series comes from what Peff sent in the following thread:
http://thread.gmane.org/gmane.comp.version-control.git/243361/focus=243528
I added the following fixes:
- add "strbuf_release(&result);" in import_object(); this was suggested by Eric Sunshine - use MODE_LIST instead of MODE_DELETE if no arguments are passed; this makes the test suite pass - add "--no-replace-objects" when calling "git cat-file" in export_object(); so that we edit the original object if an object is already replaced
I am not happy with the fact that if the user doesn't modify the object when editing it, then a replace ref can still be created that points to the original object. I think something should be done to avoid that.
Once that is fixed, I plan to add some tests and documentation, but I wanted first to let you know that I am looking at this.
Jeff King (4): replace: refactor command-mode determination replace: use OPT_CMDMODE to handle modes replace: factor object resolution out of replace_object replace: add --edit option
builtin/replace.c | 189 ++++++++++++++++++++++++++++++++++++++++++++---------- 1 file changed, 154 insertions(+), 35 deletions(-)
-- 1.9.1.636.g20d5f34