git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v1 0/4] replace: add option to edit a Git object

From
Christian Couder <chriscool@tuxfamily.org>
Date
Apr 26, 2014, 20:00 UTC
Message-ID
<20140426194404.21546.82305.chriscool@tuxfamily.org>
This patch series comes from what Peff sent in the following thread:
http://thread.gmane.org/gmane.comp.version-control.git/243361/focus=243528
I added the following fixes:
- add "strbuf_release(&result);" in import_object(); this was suggested
  by Eric Sunshine
- use MODE_LIST instead of MODE_DELETE if no arguments are passed; this
  makes the test suite pass
- add "--no-replace-objects" when calling "git cat-file" in export_object();
  so that we edit the original object if an object is already replaced

I am not happy with the fact that if the user doesn't modify the object when editing it, then a replace ref can still be created that points to the original object. I think something should be done to avoid that.

Once that is fixed, I plan to add some tests and documentation, but I wanted first to let you know that I am looking at this.

Jeff King (4):
  replace: refactor command-mode determination
  replace: use OPT_CMDMODE to handle modes
  replace: factor object resolution out of replace_object
  replace: add --edit option
 builtin/replace.c | 189 ++++++++++++++++++++++++++++++++++++++++++++----------
 1 file changed, 154 insertions(+), 35 deletions(-)
-- 
1.9.1.636.g20d5f34
Next: Christian Couder
Message 1 of 7 in “replace: add option to edit a Git object”
  1. 0/4 replace: add option to edit a Git objectChristian Couder, Apr 26, 2014
  2. 1/4 replace: refactor command-mode determinationChristian Couder, Apr 26, 2014
  3. 2/4 replace: use OPT_CMDMODE to handle modesChristian Couder, Apr 26, 2014
  4. 3/4 replace: factor object resolution out of replace_objectChristian Couder, Apr 26, 2014
  5. 4/4 replace: add --edit optionChristian Couder, Apr 26, 2014
  6. Jeff KingApr 29, 2014
  7. Junio C HamanoApr 29, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.