git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v11 00/11] Add interpret-trailers builtin

From
Christian Couder <chriscool@tuxfamily.org>
Date
Apr 25, 2014, 19:06 UTC
Message-ID
<20140425185719.28550.27059.chriscool@tuxfamily.org>
This patch series implements a new command:
        git interpret-trailers

and an infrastructure to process trailers that can be reused, for example in "commit.c".

1) Rationale:

This command should help with RFC 822 style headers, called "trailers", that are found at the end of commit messages.

(Note that these headers do not follow and are not intended to follow many rules that are in RFC 822. For example they do not follow the line breaking rules, the encoding rules and probably many other rules.)

For a long time, these trailers have become a de facto standard way to add helpful information into commit messages.

Until now git commit has only supported the well known "Signed-off-by: " trailer, that is used by many projects like the Linux kernel and Git.

It is better to keep builtin/commit.c uncontaminated by any more hard-wired logic, like what we have for the signed-off-by line. Any new things can and should be doable in hooks, and this filter would help writing these hooks.

And that is why the design goal of the filter is to make it at least as powerful as the built-in logic we have for signed-off-by lines; that would allow us to later eject the hard-wired logic for signed-off-by line from the main codepath, if/when we wanted to.

Alternatively, we could build a library-ish API around this filter code and replace the hard-wired logic for signed-off-by line with a call into that API, if/when we wanted to, but that requires (in addition to the "at least as powerful as the built-in logic") that the implementation of this stand-alone filter can be cleanly made into a reusable library, so that is a bit higher bar to cross than "everything can be doable with hooks" alternative.

2) Current state:
Currently the usage string of this command is:
git interpret-trailers [--trim-empty] [(--trailer <token>[(=|:)<value>])...] [<file>...]
The following features are implemented:
        - the result is printed on stdout
        - the --trailer arguments are interpreted
        - messages read from <file>... (new) or stdin are interpreted
        - the "trailer.<token>.key" options in the config are interpreted
        - the "trailer.<token>.where" options are interpreted
        - the "trailer.<token>.ifExist" options are interpreted
        - the "trailer.<token>.ifMissing" options are interpreted
        - the "trailer.<token>.command" config works
        - $ARG can be used in commands
        - messages can contain a patch (new)
        - there are 34 tests
        - there is some documentation
The following features are planned but not yet implemented:
        - add examples in documentation
Possible improvements:
        - integration with "git commit"
        - support GIT_COMMIT_PROTO env variable in commands
3) Changes since version 10, thanks to Michael and Junio:
* changed the usage string and the interface
* detect a patch in the input and print it if any
* adapt tests and add some related to the above changes
* improved documentation
* squashed patch to add blank lines before trailers into
  other pathes
* added git-interpret-trailers to command-list.txt
* use strcasecmp() instead of strcmp() to compare
  some values from the config file matching a fixed set

This means that only patches 1/11, 2/11, 3/11, 9/11 and 10/11 mostly did not change. I say mostly because there are still at least a commit message change in 2/11 and s/strcmp/strcasecmp/ in 3/11.

Christian Couder (11):
  trailer: add data structures and basic functions
  trailer: process trailers from input message and arguments
  trailer: read and process config information
  trailer: process command line trailer arguments
  trailer: parse trailers from file or stdin
  trailer: put all the processing together and print
  trailer: add interpret-trailers command
  trailer: add tests for "git interpret-trailers"
  trailer: execute command from 'trailer.<name>.command'
  trailer: add tests for commands in config file
  Documentation: add documentation for 'git interpret-trailers'
 .gitignore                               |   1 +
 Documentation/git-interpret-trailers.txt | 143 ++++++
 Makefile                                 |   2 +
 builtin.h                                |   1 +
 builtin/interpret-trailers.c             |  44 ++
 command-list.txt                         |   1 +
 git.c                                    |   1 +
 t/t7513-interpret-trailers.sh            | 542 ++++++++++++++++++++++
 trailer.c                                | 750 +++++++++++++++++++++++++++++++
 trailer.h                                |   6 +
 10 files changed, 1491 insertions(+)
 create mode 100644 Documentation/git-interpret-trailers.txt
 create mode 100644 builtin/interpret-trailers.c
 create mode 100755 t/t7513-interpret-trailers.sh
 create mode 100644 trailer.c
 create mode 100644 trailer.h
-- 
1.9.1.636.g20d5f34
Next: Christian Couder
Message 1 of 13 in “Add interpret-trailers builtin”
  1. 00/11 Add interpret-trailers builtinChristian Couder, Apr 25, 2014
  2. 01/11 trailer: add data structures and basic functionsChristian Couder, Apr 25, 2014
  3. 02/11 trailer: process trailers from input message and argumentsChristian Couder, Apr 25, 2014
  4. 03/11 trailer: read and process config informationChristian Couder, Apr 25, 2014
  5. 04/11 trailer: process command line trailer argumentsChristian Couder, Apr 25, 2014
  6. 05/11 trailer: parse trailers from file or stdinChristian Couder, Apr 25, 2014
  7. 06/11 trailer: put all the processing together and printChristian Couder, Apr 25, 2014
  8. 07/11 trailer: add interpret-trailers commandChristian Couder, Apr 25, 2014
  9. 08/11 trailer: add tests for "git interpret-trailers"Christian Couder, Apr 25, 2014
  10. 09/11 trailer: execute command from 'trailer.<name>.command'Christian Couder, Apr 25, 2014
  11. 10/11 trailer: add tests for commands in config fileChristian Couder, Apr 25, 2014
  12. 11/11 Documentation: add documentation for 'git interpret-trailers'Christian Couder, Apr 25, 2014
  13. Junio C HamanoApr 29, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.