Re: [PATCH v4 2/6] test: add test_write_lines helper
- From
- Michael S. Tsirkin <mst@redhat.com>
- Date
- Apr 23, 2014, 17:58 UTC
- Message-ID
- <20140423175834.GC28308@redhat.com>
- In-Reply-To
- <xmqqd2g80x21.fsf@gitster.dls.corp.google.com>
On Wed, Apr 23, 2014 at 10:34:30AM -0700, Junio C Hamano wrote:
Show 15 quoted lines
> "Michael S. Tsirkin" <mst@redhat.com> writes:
>
> > As suggested by Junio.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
>
> Ehh, I would probably not suggest such an implementation though.
>
> test_write_lines () {
> printf "%s\n" "$@"
> }
>
> might be, but not with "echo" and semicolon on the same line as
> "for" ;-).Okay I didn't know printf reuses format in bash, cute trick.
Do you want to rewrite it yourself or want me to post a new version?
Show 21 quoted lines
> > t/test-lib-functions.sh | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh
> > index aeae3ca..2fa6453 100644
> > --- a/t/test-lib-functions.sh
> > +++ b/t/test-lib-functions.sh
> > @@ -712,6 +712,13 @@ test_ln_s_add () {
> > fi
> > }
> >
> > +# This function writes out its parameters, one per line
> > +test_write_lines () {
> > + for line in "$@"; do
> > + echo "$line"
> > + done
> > +}
> > +
> > perl () {
> > command "$PERL_PATH" "$@"
> > }