[PATCH] config.c: mark die_bad_number as NORETURN

From: Jeff King <peff@peff.net>
Date: Apr 16, 2014, 16:51 UTC
Message-ID: <20140416165146.GA16695@sigill.intra.peff.net>
In-Reply-To: <534EB1FB.5040405@web.de>

On Wed, Apr 16, 2014 at 06:38:19PM +0200, Torsten Bögershausen wrote:

> > Does that also silence the warning?
> > 
> This works under gcc 4.2.1 Mac OS: the warning is away.

Thanks. I couldn't test myself, as I could not get gcc to generate the warning in the first place, but I do not have anything as old as 4.2 on hand.

Here it is with a commit message.

-- >8 --
Subject: config.c: mark die_bad_number as NORETURN

This can help avoid -Wuninitialized false positives in git_config_int and git_config_ulong, as the compiler now knows that we do not return "ret" if we hit the error codepath.

Signed-off-by: Jeff King <peff@peff.net>
---
 config.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/config.c b/config.c
index 6821cef..a30cb5c 100644
--- a/config.c
+++ b/config.c
@@ -557,6 +557,7 @@ int git_parse_ulong(const char *value, unsigned long *ret)
 	return 1;
 }
 
+NORETURN
 static void die_bad_number(const char *name, const char *value)
 {
 	const char *reason = errno == ERANGE ?

-- 
1.9.1.656.ge8a0637