Re: [PATCH] test: fix t7001 cp to use POSIX options

From: Jeff King <peff@peff.net>
Date: Apr 11, 2014, 11:43 UTC
Message-ID: <20140411114338.GD28858@sigill.intra.peff.net>
In-Reply-To: <1c3e86191de8c91545ac3ddc18fd31e@74d39fa044aa309eaea14b9f57fe79c>

On Fri, Apr 11, 2014 at 01:24:02AM -0700, Kyle J. McKay wrote:

Show 12 quoted lines

> Since 11502468 and 04c1ee57 (both first appearing in v1.8.5), the
> t7001-mv test has used "cp -a" to perform a copy in several of the
> tests.
> 
> However, the "-a" option is not required for a POSIX cp utility and
> some platforms' cp utilities do not support it.
> 
> The POSIX equivalent of -a is -R -P -p.
> 
> Change "cp -a" to "cp -R -P -p" so that the t7001-mv test works
> on systems with a cp utility that only implements the POSIX
> required set of options and not the "-a" option.

I wonder if the "-R" is the part that we actually care about here. Including the others does not hurt in that case, but using only "-R" would perhaps make it more obvious to a later reader of the code exactly what we are trying to do.

-Peff