Re: Configuring a third-party git hook
- From
Jeff King <peff@peff.net>
- Date
- Mar 21, 2014, 18:15 UTC
- Message-ID
- <20140321181532.GC15508@sigill.intra.peff.net>
- In-Reply-To
- <xmqqha6rv4og.fsf@gitster.dls.corp.google.com>
On Fri, Mar 21, 2014 at 10:31:59AM -0700, Junio C Hamano wrote:
Show 9 quoted lines
> -- >8 -- > From: Chris Angelico <rosuav@gmail.com> > Date: Fri, 21 Mar 2014 15:07:08 +1100 > Subject: [PATCH] config.txt: third-party tools may and do use their own variables > [...] > +Other git-related tools may and do use their own variables. When > +inventing new variables for use in your own tool, make sure their > +names do not conflict with what are used by Git itself and other > +popular tools, and describe them in your documentation.
I think this third line should be "with what _is_ used" to match the verb and noun pluralness[1]. Or to keep better parallel structure with the first clause, something like "...their names do not conflict with those that are used by Git...".
-Peff
[1] Is there a word to mean the "pluralness" of a noun or verb (similar
to "tense" for a verb). Surely there is, but I could not think of
it. I wanted to say here that the pluralness of "what" and "are"
does not match (it seems like "what" is a mass noun, which usually
matches a singular verb).