Re: [PATCH v2] mv: prevent mismatched data when ignoring errors.

From: Jeff King <peff@peff.net>
Date: Mar 16, 2014, 02:00 UTC
Message-ID: <20140316020051.GB20019@sigill.intra.peff.net>
In-Reply-To: <1394909812-92472-1-git-send-email-sandals@crustytoothpaste.net>

On Sat, Mar 15, 2014 at 06:56:52PM +0000, brian m. carlson wrote:

Show 12 quoted lines

> We shrink the source and destination arrays, but not the modes or
> submodule_gitfile arrays, resulting in potentially mismatched data.  Shrink
> all the arrays at the same time to prevent this.  Add tests to ensure the
> problem does not recur.
> 
> Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
> ---
> 
> I attempted to come up with a second patch that would refactor out the
> four different arrays into one array of struct, as Jeff suggested, but
> it became very ugly very quickly.  So this patch simply fixes the
> problem and adds tests.

>From my brief look, I feared that might be the case. Oh well, thanks for

trying.

-Peff