[PATCH 2/2] pack-objects: show reused packfile objects in "Counting objects"
- From
Jeff King <peff@peff.net>
- Date
- Mar 15, 2014, 02:26 UTC
- Message-ID
- <20140315022658.GB987@sigill.intra.peff.net>
- In-Reply-To
- <20140315022550.GA875@sigill.intra.peff.net>
When we are sending a pack for push or fetch, we may reuse a chunk of packfile without even parsing it. The progress meter then looks like this:
Reusing existing pack: 3440489, done. Counting objects: 3, done.
The first line shows that we are reusing a large chunk of objects, and then we further count any objects not included in the reused portion with an actual traversal.
These are all implementation details that the user does not need to care about. Instead, we can show the reused objects in the normal "counting..." progress meter (which will simply go much faster than normal), and then continue to add to it as we traverse.
Signed-off-by: Jeff King <peff@peff.net> --- builtin/pack-objects.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c index 12aa94c..4ca3946 100644 --- a/builtin/pack-objects.c +++ b/builtin/pack-objects.c @@ -1038,7 +1038,7 @@ static int add_object_entry(const unsigned char *sha1, enum object_type type, exclude, name && no_try_delta(name), index_pos, found_pack, found_offset); - display_progress(progress_state, to_pack.nr_objects); + display_progress(progress_state, nr_result); return 1; } @@ -1054,7 +1054,7 @@ static int add_object_entry_from_bitmap(const unsigned char *sha1, create_object_entry(sha1, type, name_hash, 0, 0, index_pos, pack, offset); - display_progress(progress_state, to_pack.nr_objects); + display_progress(progress_state, nr_result); return 1; } @@ -2456,12 +2456,7 @@ static int get_object_list_from_bitmap(struct rev_info *revs) &reuse_packfile_offset)) { assert(reuse_packfile_objects); nr_result += reuse_packfile_objects; - - if (progress) { - fprintf(stderr, "Reusing existing pack: %d, done.\n", - reuse_packfile_objects); - fflush(stderr); - } + display_progress(progress_state, nr_result); } traverse_bitmap_commit_list(&add_object_entry_from_bitmap);
-- 1.9.0.417.gc6bea4f