Re: Corner case bug caused by shell dependent behavior

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Mar 14, 2014, 00:37 UTC
Message-ID: <20140314003701.GF15625@google.com>
In-Reply-To: <20140314000213.GA3739@ibr.ch>

Hi,

Uwe Storbeck wrote:

Show 10 quoted lines

> To reproduce the behavior (with dash as /bin/sh):
>
>   mkdir test && cd test && git init
>   echo 1 >foo && git add foo
>   git commit -m"this commit message ends with '\n'"
>   echo 2 >foo && git commit -a --fixup HEAD
>   git rebase -i --autosquash --root
>
> Now the editor opens with garbage in line 3 which has to be
> removed or the rebase fails.

Would it make sense to add this as a test to e.g. t/t3404-rebase-interactive.sh?

> The attached one-line patch fixes the bug.

May we have your sign-off? (See Documentation/SubmittingPatches section "Sign your work" for what this means.

Looks obviously correct, so for what it's worth,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Thanks, Jonathan