Re: [PATCH] clean: respect pathspecs with "-d"

From: Simon Ruderich <simon@ruderich.org>
Date: Mar 10, 2014, 20:02 UTC
Message-ID: <20140310200235.GA14112@ruderich.org>
In-Reply-To: <20140310172215.GC29801@sigill.intra.peff.net>

On Mon, Mar 10, 2014 at 01:22:15PM -0400, Jeff King wrote:

Show 9 quoted lines

> +test_expect_success 'git clean -d respects pathspecs' '
> +	mkdir foo &&
> +	mkdir foobar &&
> +	git clean -df foobar &&
> +	test_path_is_dir foo &&
> +	test_path_is_missing foobar
> +'
> +
>  test_done

I think we should also test removing foo, which was also in the original report, to make sure we don't match prefixes, e.g.:

test_expect_success 'git clean -d respects pathspecs' '
	mkdir foo &&
	mkdir foobar &&
	git clean -df foo &&
	test_path_is_missing foo &&
	test_path_is_dir foobar
'

Regards Simon

-- 
+ privacy is necessary
+ using gnupg http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9