Re: [PATCH v2] tag: support --sort=<spec>

From: Jeff King <peff@peff.net>
Date: Feb 24, 2014, 23:33 UTC
Message-ID: <20140224233303.GA27689@sigill.intra.peff.net>
In-Reply-To: <CACsJy8CRe4MmkTnuChOi2SHG52tx_LZ+51vWXN9ooGmcRUN7bQ@mail.gmail.com>

On Tue, Feb 25, 2014 at 06:30:35AM +0700, Duy Nguyen wrote:

Show 13 quoted lines

> >>> +[ "$(uname -o)" = "GNU/Linux" ] && test_set_prereq GNULINUX
> >>> +
> >>
> >> can pick up the value from GIT-BUILD-OPTIONS as a prerequisite (see the
> >> way we handle NO_PERL for an example). Though if we can just grab the
> >> glibc version as a fallback, we can do away with that completely.
> >
> > ;-)  I like that.
> >
> 
> Jeff, I'm still waiting if you agree to go with this syntax or put
> version before refname before rerolling (either with build time option
> like this, or implement the compat function myself).

Sorry. I didn't respond because I was trying to think of something to say besides "no, I still like mine better". I admit that it's mostly a gut feeling, and I don't have any argument beyond what I've already made (your "it's like a typecast" does make some sense, but I think that is a convoluted way of thinking about it).

-Peff