[PATCH 01/13] Makefile: drop USE_GETTEXT_SCHEME from GIT-CFLAGS
- From
Jeff King <peff@peff.net>
- Date
- Feb 5, 2014, 17:49 UTC
- Message-ID
- <20140205174901.GA15218@sigill.intra.peff.net>
- In-Reply-To
- <20140205174823.GA15070@sigill.intra.peff.net>
This variable is used only by shell scripts, not by C programs. It was originally included in GIT-CFLAGS as part of ad17ea7 (add a Makefile switch to avoid gettext translation in shell scripts, 2012-01-23), in an attempt to trigger rebuilding when the variable changed.
However, shell scripts do not respect GIT-CFLAGS. Later, e4dd89a (Makefile: update scripts when build-time parameters change, 2012-06-20) introduced a separate GIT-SCRIPT-DEFINES to accomplish this, which also included USE_GETTEXT_SCHEME. We can drop the redundant and useless mention in GIT-CFLAGS.
Signed-off-by: Jeff King <peff@peff.net> --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile index dddaf4f..3cd4a92 100644 --- a/Makefile +++ b/Makefile @@ -2164,7 +2164,7 @@ GIT-PREFIX: FORCE echo "$$FLAGS" >GIT-PREFIX; \ fi -TRACK_CFLAGS = $(CC):$(subst ','\'',$(ALL_CFLAGS)):$(USE_GETTEXT_SCHEME) +TRACK_CFLAGS = $(CC):$(subst ','\'',$(ALL_CFLAGS)) GIT-CFLAGS: FORCE @FLAGS='$(TRACK_CFLAGS)'; \
-- 1.8.5.2.500.g8060133