git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] userdiff: update Ada patterns

From
Jeff King <peff@peff.net>
Date
Feb 5, 2014, 17:28 UTC
Message-ID
<20140205172844.GD7268@sigill.intra.peff.net>
In-Reply-To
<xmqqk3d95vic.fsf@gitster.dls.corp.google.com>
On Wed, Feb 05, 2014 at 09:17:47AM -0800, Junio C Hamano wrote:
Show 18 quoted lines
> Adrian Johnson <ajohnson@redneon.com> writes:
> 
> >>> -	 "|[0-9][-+0-9#_.eE]"
> >>> +	 "|[-+]?[0-9][0-9#_.aAbBcCdDeEfF]*([eE][+-]?[0-9_]+)?"
> >> 
> >> This would match a lot wider than what I read you said you wanted to
> >> match in your previous message.  Does "-04##4_3_2Ee-9" count as a
> >> number, for example, or can we just ignore such syntactically
> >> incorrect sequence?
> >
> > Maybe I am misunderstanding the purpose of the word diff regexes. I
> > thought the purpose of the word regex is to split lines into words, not
> > determine what is syntactically correct.
> 
> I agree that the purpose is former---So you could have just said
> "the latter" ;-).
> 
> Any other nitpick, anybody?  Otherwise I'll queue this version.

No nitpick here, I had the same thought as Adrian while reading the thread (and if somebody comes up with a real case where the output looks bad, we can iterate on it).

-Peff
Previous: Junio C Hamano
Message 8 of 8 in “userdiff: update Ada patterns”
  1. userdiff: update Ada patternsAdrian Johnson, Feb 2, 2014
  2. Jeff KingFeb 2, 2014
  3. Adrian JohnsonFeb 3, 2014
  4. userdiff: update Ada patternsAdrian Johnson, Feb 3, 2014
  5. Junio C HamanoFeb 3, 2014
  6. Adrian JohnsonFeb 5, 2014
  7. Junio C HamanoFeb 5, 2014
  8. Jeff KingFeb 5, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.