Re: What's cooking in git.git (Jan 2014, #05; Mon, 27)

From: Jeff King <peff@peff.net>
Date: Jan 28, 2014, 00:40 UTC
Message-ID: <20140128004042.GC17227@sigill.intra.peff.net>
In-Reply-To: <xmqq7g9lnkjz.fsf@gitster.dls.corp.google.com>

On Mon, Jan 27, 2014 at 02:09:52PM -0800, Junio C Hamano wrote:

Show 17 quoted lines

> [Stalled]
> 
> * jk/color-for-more-pagers (2014-01-17) 4 commits
>  - pager: disable colors for some known-bad configurations
>  - DONOTMERGE: needs matching change to git-sh-setup
>  - setup_pager: set MORE=R
>  - setup_pager: refactor LESS/LV environment setting
> 
>  'more' implementation of BSD wants to be told with MORE=R
>  environment before it shows colored output, while 'more' on some
>  other platforms will die when seeing MORE=R environment.
> 
>  It appears that we are coming to the consensus that trying to be
>  too intimately knowledgeable about quirks of various pager
>  implementations on different platforms is a losing proposition, so
>  perhaps I should replace this with the alternative and simpler
>  approach I posted, unless there are strong objections.

It saddens me that we can't better help people who have a custom LESS/MORE/LV set out of the box, but I think I agree that the intimacy with the pagers was just getting too ugly. So I agree we want to drop what you have there.

I was planning to try to clean up the "like this..." patch to the Makefile I posted earlier, but haven't gotten around to it. It seemed like you were positive on that approach. Let me see if I can do that.

-Peff