Re: [PATCH] repack.c: chmod +w before rename()

From: Mike Hommey <mh@glandium.org>
Date: Jan 24, 2014, 23:50 UTC
Message-ID: <20140124235048.GA30427@glandium.org>
In-Reply-To: <20140124224911.GC58260@vauxhall.crustytoothpaste.net>

On Fri, Jan 24, 2014 at 10:49:13PM +0000, brian m. carlson wrote:

Show 12 quoted lines

> On Fri, Jan 24, 2014 at 11:24:36PM +0100, Johannes Schindelin wrote:
> > > In general, I'm wary of changing permissions on a file to suit Windows's
> > > rename because of the symlink issue and the security issues that can
> > > result.
> > 
> > I agree on the Windows issue.
> 
> I personally feel that if Windows needs help to change permissions for a
> rename, that code should only ever be used on Windows.  Doesn't
> mingw_rename automatically do this anyway, and if it doesn't, shouldn't
> we put the code there instead?  Furthermore, it makes me very nervous to
> make the file 666.  Isn't 644 enough?

Arguably, umask is supposed to take care of making things right. OTOH, since it's the destination file that's the problem not the renamed file, the equivalent to mv -f would be to unlink() that file first, not to change its permissions. That would work properly on unix too.

Mike