git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 0/2] performance regression in mark_edges_uninteresting

From
Jeff King <peff@peff.net>
Date
Jan 21, 2014, 02:24 UTC
Message-ID
<20140121022431.GA4614@sigill.intra.peff.net>
In-Reply-To
<20140120212845.GA11451@sigill.intra.peff.net>
On Mon, Jan 20, 2014 at 04:28:45PM -0500, Jeff King wrote:
Show 14 quoted lines
> This series fixes a rev-list performance regression in fbd4a70 (list-objects:
> mark more commits as edges in mark_edges_uninteresting, 2013-08-16).  That
> commit is a little tricky because it actually _knows_ it's trading off CPU for
> a better packfile, but I think we're performing the tradeoff in too many
> places. See the second commit for details.
> 
>   [1/2]: t/perf: time rev-list with UNINTERESTING commits
>   [2/2]: list-objects: only look at cmdline trees with edge_hint
> 
> Here's t/perf/p0001 output that shows the problem:
> 
>   0001.5: rev-list --objects $commit --not --all
>   fbd4a703^         fbd4a703                  HEAD
>   0.04(0.04+0.00)   0.28(0.27+0.00) +600.0%   0.04(0.04+0.00) +0.0%

Here's v2 that addresses the minor comments on the list (simpler test in the first patch, and dropping the now-redundant revs->edge_hint check in the second patch).

-Peff
Previous: Jeff KingNext: Jeff King
Message 10 of 13 in “performance regression in mark_edges_uninteresting”
  1. 0/2 performance regression in mark_edges_uninterestingJeff King, Jan 20, 2014
  2. 1/2 t/perf: time rev-list with UNINTERESTING commitsJeff King, Jan 20, 2014
  3. Jeff KingJan 20, 2014
  4. Thomas RastJan 20, 2014
  5. Jeff KingJan 20, 2014
  6. 2/2 list-objects: only look at cmdline trees with edge_hintJeff King, Jan 20, 2014
  7. Duy NguyenJan 20, 2014
  8. Jeff KingJan 21, 2014
  9. Jeff KingJan 20, 2014
  10. 0/2 performance regression in mark_edges_uninterestingJeff King, Jan 21, 2014
  11. 1/2 t/perf: time rev-list with UNINTERESTING commitsJeff King, Jan 21, 2014
  12. 2/2 list-objects: only look at cmdline trees with edge_hintJeff King, Jan 21, 2014
  13. Junio C HamanoJan 21, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.