Re: git quietly fails on https:// URL, https errors are never reported to user
- From
Jeff King <peff@peff.net>
- Date
- Jan 17, 2014, 20:18 UTC
- Message-ID
- <20140117201858.GA3362@sigill.intra.peff.net>
- In-Reply-To
- <20140117201325.GB775@sigill.intra.peff.net>
On Fri, Jan 17, 2014 at 03:13:25PM -0500, Jeff King wrote:
Show 14 quoted lines
> On Fri, Jan 17, 2014 at 11:43:35AM -0800, Junio C Hamano wrote: > > > Yuri <yuri@rawbw.com> writes: > > > > > I think that in a rare case of error this extra-printout wouldn't > > > hurt. > > > > If the "error is rare, extra verbiage does not hurt" were a valid > > attitude, "error is rare, non-zero exit is enough" would be equally > > valid ;-) > > I think the problem is that error is _not_ rare. For years, we did not > print the extra verbiage, and nobody complained. Then, within days of us > making a release that included the extra line, somebody complained[1].
Forgot my footnote here, but it was:
http://article.gmane.org/gmane.comp.version-control.git/228498
which led to 266f1fd (transport-helper: be quiet on read errors from helpers, 2013-06-21).
-Peff