Re: Bug report: stash in upstream caused remote fetch to fail

From: Jeff King <peff@peff.net>
Date: Jan 15, 2014, 10:48 UTC
Message-ID: <20140115104826.GF14335@sigill.intra.peff.net>
In-Reply-To: <20140115104612.GE14335@sigill.intra.peff.net>

On Wed, Jan 15, 2014 at 05:46:13AM -0500, Jeff King wrote:

Show 6 quoted lines

> This discussion stalled, but I finally got around to looking at it
> today. I agree that we should leave aside more complex policy for now,
> and start with bringing the "fetch" and "fetch-pack" filters into
> harmony. That turns off format-checking for things outside "refs/" (so
> allows "HEAD"), and checks the whole string for things inside "refs/"
> (so it does not fall afoul of the one-level check).

By the way, an interesting implication of this is that I do not think there is any format check on things outside of refs/. If you were to do

  git fetch ... +*:*

you would write whatever crap the other side gives you. I can't imagine any reason a client would _ever_ do that, though, so I don't think it's a big deal. We tend to fetch HEAD explicitly by name, and that's it.

-Peff