Re: git gui crashes ( v 1.8.5.2)

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jan 14, 2014, 01:11 UTC
Message-ID: <20140114011141.GF18964@google.com>
In-Reply-To: <CANJSc_uYm7f4LoZoMoVzcsmGrYnUy+2nXFL_cNWqQnwLb5J6mw@mail.gmail.com>

(just cc-ing some area experts) Hi Benoît,

Benoît Bourbié wrote:

> git gui crashes on my Linux machin since I updated it to 1.8.5.2.

I assume you mean "master" and not 1.8.5.2, since v1.8.5.2 doesn't include the change 918dbf58 (git-gui: right half window is paned, 2013-08-21).

Show 35 quoted lines

> I had the message
> Error in startup script: unknown option "-stretch"
>     while executing
> ".vpane.lower paneconfigure .vpane.lower.diff -stretch always"
>     invoked from within
> "if {$use_ttk} {
> .vpane.lower pane .vpane.lower.diff -weight 1
> .vpane.lower pane .vpane.lower.commarea -weight 0
> } else {
> .vpane.lower paneconfigure..."
>     (file "git/libexec/git-core/git-gui" line 3233)
>
> So, I reverted the change that has been made in git-gui/git-gui.sh
> (Diff and Commit Area)
>
> I replaced
>
> ${NS}::panedwindow .vpane.lower -orient vertical
> ${NS}::frame .vpane.lower.commarea
> ${NS}::frame .vpane.lower.diff -relief sunken -borderwidth 1 -height 500
> .vpane.lower add .vpane.lower.diff
> .vpane.lower add .vpane.lower.commarea
> .vpane add .vpane.lower
>
> by
>
> ${NS}::frame .vpane.lower -height 300 -width 400
> ${NS}::frame .vpane.lower.commarea
> ${NS}::frame .vpane.lower.diff -relief sunken -borderwidth 1
> pack .vpane.lower.diff -fill both -expand 1
> pack .vpane.lower.commarea -side bottom -fill x
> .vpane add .vpane.lower
> if {!$use_ttk} {.vpane paneconfigure .vpane.lower -sticky nsew}
>
> and now, git gui works as expected.

Thanks, Jonathan