Re: [PATCH] git-p4: Do not include diff in spec file when just preparing p4

From: Pete Wyckoff <pw@padd.com>
Date: Jan 12, 2014, 22:29 UTC
Message-ID: <20140112222946.GA13519@padd.com>
In-Reply-To: <20140110181807.GA29164@nekage>

frrrwww@gmail.com wrote on Fri, 10 Jan 2014 18:18 +0000:

> The diff information render the spec file unusable as is by p4,
> do not include it when run with --prepare-p4-only so that the
> given file can be directly passed to p4.

Thanks for the patch, but I'm curious how you'd like this to work. I never use the option myself.

As it is, --prepare-p4-only generates a file in /tmp/ that has exactly the contents you'd see in the editor during "git p4 submit". It includes the diff of the change, presumably to help with writing the description.

Now you can't actually feed this file directly to "p4 submit" without deleting the diff. That's the part you don't like?

		-- Pete