Re: [PATCH 1/2] cat-file: pass expand_data to print_object_or_die

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Dec 11, 2013, 20:11 UTC
Message-ID: <20131211201112.GM2311@google.com>
In-Reply-To: <20131211115642.GA10594@sigill.intra.peff.net>

Hi,

Jeff King wrote:

>                                        However, if we pass
> the whole struct, the called function can make more
> intelligent decisions about which fields were actualled
> filled by sha1_object_info.

Thanks.

s/actualled/actually/, I think.

At first I thought this patch was going to be about making those intelligent decisions. Maybe s/the called function can/a future patch can teach the called function/ or something?

[...]

> There should be no functional change to this patch.

The patch itself looks straightforward, yep. :)

With the typofix mentioned above,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>