git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] parse-options: remove OPT_BOOLEAN

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Dec 8, 2013, 22:23 UTC
Message-ID
<20131208222352.GA9108@google.com>
In-Reply-To
<1386392573-27367-1-git-send-email-pclouds@gmail.com>
Hi,
Nguyễn Thái Ngọc Duy wrote:
> After a86a8b9 (sb/parseopt-boolean-removal), the deprecated
> OPT_BOOLEAN is not used anywhere except by OPT__* macros.
Yeah, I noticed the same thing too recently.
[...]
>                                              All OPT__DRY_RUN call
> sites have been checked and they look safe for OPT_BOOL.

This is the only functional change from the patch. A repeated --dry-run that behaves differently from --dry-run would be very weird, and a quick check of OPT__DRY_RUN uses in pu confirms that with current callers the patch is a no-op (except in the weird case that someone overflows an "int" with a very long -nnnnnnn... commandline).

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Thanks.
Previous: Nguyễn Thái Ngọc Duy
Message 2 of 2 in “parse-options: remove OPT_BOOLEAN”
  1. parse-options: remove OPT_BOOLEANNguyễn Thái Ngọc Duy, Dec 7, 2013
  2. Jonathan NiederDec 8, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.