git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: error: git-remote-https died of signal 13

From
Jeff King <peff@peff.net>
Date
Nov 25, 2013, 14:32 UTC
Message-ID
<20131125143213.GA22642@sigill.intra.peff.net>
In-Reply-To
<alpine.DEB.2.00.1311250815150.27300@tvnag.unkk.fr>
On Mon, Nov 25, 2013 at 08:20:18AM +0100, Daniel Stenberg wrote:
Show 11 quoted lines
> >Daniel, does the call to Curl_disconnect need to be wrapped with
> >sigpipe_ignore/reset, similar to 7d80ed64e435155?
> 
> Yes. It very much looks like that. The SSL "closing" is what was the
> problem I had to adress.
> 
> But I then decided that if a 3rd library has one way to generate
> SIGPIPE it may very well have another in a separate spot so I decided
> to do the wrap at the top level immediately in the entry point when
> getting called by the application. Following that, the SIGPIPE
> ignore/restore should rather be made in curl_multi_cleanup.

Unfortunately, we need an actual SessionHandle to know whether it is OK to reset signals at all. There may be a more elegant way of checking that, but here's the patch series I came up with. It does turn off SIGPIPE for the specific case I'm seeing (again, I'm having trouble actually getting EPIPE in the first place, but from Stefan's strace, I think this would fix his problem).

  [1/2]: factor out sigpipe_reset from easy.c
  [2/2]: ignore SIGPIPE during curl_multi_cleanup
-Peff
Previous: Daniel StenbergNext: Jeff King
Message 11 of 22 in “error: git-remote-https died of signal 13”
  1. Stefan BellerNov 23, 2013
  2. Jeff KingNov 24, 2013
  3. Stefan BellerNov 24, 2013
  4. Jeff KingNov 24, 2013
  5. Stefan BellerNov 24, 2013
  6. Jeff KingNov 24, 2013
  7. Stefan BellerNov 24, 2013
  8. Stefan BellerNov 24, 2013
  9. Jeff KingNov 25, 2013
  10. Daniel StenbergNov 25, 2013
  11. Jeff KingNov 25, 2013
  12. 1/2 factor out sigpipe_reset from easy.cJeff King, Nov 25, 2013
  13. 2/2 ignore SIGPIPE during curl_multi_cleanupJeff King, Nov 25, 2013
  14. Daniel StenbergNov 27, 2013
  15. curlUserMay 22, 2018
  16. Daniel StenbergMay 22, 2018
  17. curlUserMay 22, 2018
  18. dxt29Aug 3, 2018
  19. Jeff KingNov 25, 2013
  20. Daniel StenbergNov 24, 2013
  21. brian m. carlsonNov 24, 2013
  22. Daniel StenbergMay 22, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.