Re: [PATCH v6 05/10] git fetch-pack: Add --diag-url
- From
SZEDER Gábor <szeder@ira.uka.de>
- Date
- Nov 22, 2013, 12:56 UTC
- Message-ID
- <20131122125629.GB9273@goldbirke>
- In-Reply-To
- <201311212140.49698.tboegi@web.de>
Hi,
On Thu, Nov 21, 2013 at 09:40:48PM +0100, Torsten Bögershausen wrote:
Show 10 quoted lines
> diff --git a/t/t5500-fetch-pack.sh b/t/t5500-fetch-pack.sh
> index d87ddf7..9136f2a 100755
> --- a/t/t5500-fetch-pack.sh
> +++ b/t/t5500-fetch-pack.sh
> @@ -531,5 +531,62 @@ test_expect_success 'shallow fetch with tags does not break the repository' '
> git fsck
> )
> '
> +check_prot_path() {
> + > actual &&There is no need to truncate actual here, ...
> + (git fetch-pack --diag-url "$1" 2>&1 1>stdout) | grep -v host= >actual &&
... because it will be overwritten in this line anyway.
Show 9 quoted lines
> + echo "Diag: url=$1" >expected &&
> + echo "Diag: protocol=$2" >>expected &&
> + echo "Diag: path=$3" >>expected &&
> + test_cmp expected actual
> +}
> +
> +check_prot_host_path() {
> + > actual &&
> + git fetch-pack --diag-url "$1" 2>actual &&Likewise.
Best, Gábor