git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t7507-*.sh: Fix test #8 (could not run '"$FAKE_EDITOR"')

From
Jeff King <peff@peff.net>
Date
Nov 20, 2013, 19:01 UTC
Message-ID
<20131120190129.GA7285@sigill.intra.peff.net>
In-Reply-To
<20131120185420.GA11404@sigill.intra.peff.net>
On Wed, Nov 20, 2013 at 01:54:20PM -0500, Jeff King wrote:
> I'm not sure why the old $FAKE_EDITOR doesn't work there, though (not
> that it would make the test pass anyway, as it does something different
> than what the test wants, but I would not expect the shell to complain
> of failure).
Oh, I see. The original FAKE_EDITOR is:
  exec grep '^diff --git' "\$1"

But the whole point of the test is that we do not have such a "diff" header, being only a submodule update, and so grep exits non-zero, and git thinks the editor has failed.

So mystery solved, and the sole problem is the proper setting of the variable.

-Peff
Previous: Jeff KingNext: Ramsay Jones
Message 6 of 8 in “t7507-*.sh: Fix test #8 (could not run '"$FAKE_EDITOR"')”
  1. t7507-*.sh: Fix test #8 (could not run '"$FAKE_EDITOR"')Ramsay Jones, Nov 20, 2013
  2. Junio C HamanoNov 20, 2013
  3. Jeff KingNov 20, 2013
  4. Junio C HamanoNov 20, 2013
  5. Jeff KingNov 20, 2013
  6. Jeff KingNov 20, 2013
  7. Ramsay JonesNov 20, 2013
  8. Jens LehmannNov 20, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.