git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git-remote-mediawiki: do not remove installed files in "clean" target

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Nov 9, 2013, 02:22 UTC
Message-ID
<20131109022239.GI10302@google.com>

Running "make clean" after a successful "make install" should not result in a broken mediawiki remote helper.

Reported-by: Thorsten Glaser <t.glaser@tarent.de>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---
Thanks for the very pleasant mediawiki remote helper.
 contrib/mw-to-git/Makefile | 1 -
 1 file changed, 1 deletion(-)
diff --git a/contrib/mw-to-git/Makefile b/contrib/mw-to-git/Makefile
index f206f96..c5547f9 100644
--- a/contrib/mw-to-git/Makefile
+++ b/contrib/mw-to-git/Makefile
@@ -43,7 +43,6 @@ install: install_pm
 clean:
 	$(MAKE) -C $(GIT_ROOT_DIR) SCRIPT_PERL="$(SCRIPT_PERL_FULL)" \
                 clean-perl-script
-	rm $(INSTLIBDIR)/$(GIT_MEDIAWIKI_PM)
 
 perlcritic:
 	perlcritic -5 $(SCRIPT_PERL)
-- 
1.8.4.1
Next: Matthieu Moy
Message 1 of 7 in “git-remote-mediawiki: do not remove installed files in "clean" target”
  1. git-remote-mediawiki: do not remove installed files in "clean" targetJonathan Nieder, Nov 9, 2013
  2. Matthieu MoyNov 9, 2013
  3. Jonathan NiederNov 11, 2013
  4. 1/3 git-remote-mediawiki: honor DESTDIR in "make install"Jonathan Nieder, Nov 11, 2013
  5. 2/3 git-remote-mediawiki build: make 'install' command configurableJonathan Nieder, Nov 11, 2013
  6. 3/3 git-remote-mediawiki build: handle DESTDIR/INSTLIBDIR with whitespaceJonathan Nieder, Nov 11, 2013
  7. Matthieu MoyNov 11, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.